Skip to content

Conversation

@pictos
Copy link
Contributor

@pictos pictos commented Feb 1, 2025

@learn-build-service-prod
Copy link

Learn Build status updates of commit 2347861:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/maui/platform-specific/DialogFragment-customization.md ⚠️Warning View Details

docs/maui/platform-specific/DialogFragment-customization.md

  • Line 3, Column 9: [Warning: author-not-found - See documentation] Invalid value for author: 'Pedro Jesus' is not a valid GitHub ID.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 7c4d79d:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/platform-specific/DialogFragment-customization.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pictos thank you for this. I have added some comments, please let me know what you think

Co-authored-by: Shaun Lawrence <shaunrlawrence@gmail.com>
@learn-build-service-prod
Copy link

Learn Build status updates of commit c28874a:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/platform-specific/DialogFragment-customization.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 485e2d1:

✅ Validation status: passed

File Status Preview URL Details
docs/maui/platform-specific/DialogFragment-customization.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@pictos pictos requested a review from bijington February 11, 2025 12:57
Copy link
Collaborator

@bijington bijington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @pictos

@jfversluis jfversluis merged commit e6084f5 into MicrosoftDocs:main Feb 14, 2025
2 checks passed
@pictos pictos deleted the pj/IdialogFragmentService branch February 14, 2025 20:17
ZivFarin added a commit to ZivFarin/CommunityToolkit that referenced this pull request Apr 30, 2025
…droid

While [this page](https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/platform-specific/dialogfragment-customization#usage) explains how to achieve this behavior, including this information here helps surface the solution more directly and saves others from needing to dig through issue discussions.


Note:
After finding this - I searched for "Dialog Fragment Service" in the docs, but couldn't find it.
Only way was through [this github issue](MicrosoftDocs#511).
Shouldn't this be made more accessible?


Based on:
CommunityToolkit/Maui#2413
MicrosoftDocs#511
https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/platform-specific/dialogfragment-customization#usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants